Repository navigation
Take the page's scan result from frame 0 only - #35
Merged
Merged
Conversation
A frame of another origin learns its path from the frame that read the document it sits in, over postMessage, and the page's own scripts can see and answer that message too. A page lying to one of its frames could hand it the path "0", and the worker took the page's result by that path alone, last writer winning, so that frame's records would have replaced the whole page in the scan. The page's result now comes only from frame 0, an id Chrome sets. Any other made-up path was never used: frames are taken from the kids list of the frame that read them. The fallback reader for pages the extension cannot script already returns the page as frame 0.
FunctionFreak
added a commit
that referenced
this pull request
Nov 5, 2026
New AutoCua/utils/errors.py, error_text(e): the message an exception carries (its args; strerror and filename for OS errors; timeout or exit status for subprocess errors), built from the exception's fields and never from str(e) or a traceback. The sixteen JSON replies in the app's Flask routes, the iOS and Android connectors and the three Telegram views use it in place of str(e). What the person sees stays the same, minus the "[Errno N]" prefix. Closes the fourteen open py/stack-trace-exposure alerts (#5, #8-#15, #27, #30-#32, #35), which treat str(e) of a caught exception as stack-trace text once it reaches a reply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A frame of another origin learns its path from the frame that read the document it sits in, over postMessage, and the page's own scripts can see and answer that message too. A page lying to one of its frames could hand it the path "0", and the worker took the page's result by that path alone, last writer winning, so that frame's records would have replaced the whole page in the scan. The page's result now comes only from frame 0, an id Chrome sets. Any other made-up path was never used: frames are taken from the kids list of the frame that read them. The fallback reader for pages the extension cannot script already returns the page as frame 0.